Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dead/unused Go helper functions across the workflow package and updates the dead-code removal guide to document the correct process and a batch-by-batch plan for future cleanups.
Changes:
- Deleted unused parser/config helper functions in
pkg/workflow/safe_output_parser.goand frontmatter extraction wrappers inpkg/workflow/frontmatter_types.go. - Removed unused permission factory constructors in
pkg/workflow/permissions_factory.goand a dead JS getter stub inpkg/workflow/js.go. - Expanded and corrected
DEADCODE.mdwith methodology, pitfalls, and a structured batch plan/checklist.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/safe_output_parser.go | Removes unused exported parsing helpers for discussion/close/list configs. |
| pkg/workflow/permissions_factory.go | Removes unused permission-constructor helpers. |
| pkg/workflow/js.go | Removes an unused internal JS getter stub. |
| pkg/workflow/frontmatter_types.go | Removes unused convenience wrappers for string/int extraction. |
| DEADCODE.md | Adds correct methodology, pitfalls, and a detailed multi-batch removal plan/checklist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions_factory.go,frontmatter_types.go,safe_output_parser.go, andjs.goDEADCODE.mdwith a structured multi-batch removal plan (batches 5–16) and correct methodology for handling test-only callers